Missing "Bookmark This Link" context menu item for selected text link

[cndouglas]

Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:
The context menu for links does not have the "Bookmark This Link" item.

Here is the code that is supposed to show the item.

Expected behavior:
When I right-click a link, there should be an option to bookmark it.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  macOS 10.11.6
• Brave Version:
  0.12.0
• Steps to reproduce:
  1. Go to a page with a hyperlink (e.g., https://github.com/brave/browser-laptop)
  2. Right-click the hyperlink (e.g., browser-laptop)
• Screenshot if needed:
  
• Any related issues:
  The spec is in contextual menus upgrade #1253.

[luixxiul]

This has been implemented on Windows already. Is this macOS-only?

[cndouglas]

Possibly. Can anyone else confirm on macOS or Linux?

[luixxiul]

it does not exist on macOS

[cndouglas]

That's strange. It's consistently reproducible for me with both 0.12.1 and 0.12.2-RC4. macOS 10.12.

[cndouglas]

I've discovered the problem. It only occurs when the link text is selected. "Bookmark this page" shows for non-text links (e.g. image links).

Text links are automatically selected on right-click on macOS, so I'll mark this macOS-only. I'm investigating a fix…

[cndouglas]

#4462 fixes the issue for me.