-
Notifications
You must be signed in to change notification settings - Fork 975
1Password is not filling the form and Brave is saving the password #3897
Comments
open pages must be reloaded after enabling 1password. That part is a 1password issue and is the same on Chrome and Safari. The Brave password manager save issue seems incorrect thought |
i can't repro the Brave-offering-to-save-passwords issue after enabling 1pw on OS X |
@alexwykoff can you confirm was this just because you needed to reload the page? If so let's kick it out of 0.12.1 |
Indeed, reloading the page worked. Pushing this out to the next milestone. |
if it was just a reload issue I think we should close the ticket or change the fix to adding a notification that pages must be reloaded before 1pw will work
|
Ya I'm going to mark this as wontfix, it's ok to make the user reload when changing this setting if they want to use. |
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
When attempting to log into a website (ex: github.com) I tried to use 1Password after setting the preference in Brave. 1Password did not fill the form and after copying the password into the form, Brave offered to save it. If I chose yes, it was saved into about:passwords.
Expected behavior:
If I choose 1Password to manage my passwords, it should fill the login form and Brave should not offer to save the password.
Tested on OS X
0.12.0
The text was updated successfully, but these errors were encountered: