Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add margin-left to the notification button #3945

Merged
merged 1 commit into from
Sep 13, 2016
Merged

Add margin-left to the notification button #3945

merged 1 commit into from
Sep 13, 2016

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Sep 13, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

The value is based on padding-top here: https://github.com/brave/browser-laptop/blob/master/less/notificationBar.less#L16

Addresses #3939

Auditors: @ayumi

Test Plan:

  1. Go to https://trac.torproject.org/projects/tor
  2. Log in with your username and password
  3. Change the window size

screenshot 2016-09-13 14 44 41

Addresses #3939

Auditors: @ayumi

Test Plan:

1. Go to https://trac.torproject.org/projects/tor
2. Log in with your username and password
3. Change the window size
@ayumi
Copy link
Contributor

ayumi commented Sep 13, 2016

Thanks! Tried it out locally, looks sweet ++ 🎁

@ayumi ayumi merged commit 5f74a75 into brave:master Sep 13, 2016
@luixxiul luixxiul added this to the 0.12.1dev milestone Sep 15, 2016
@luixxiul luixxiul deleted the notificationBar-options branch September 24, 2016 02:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants