Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Default Payments publisherURL protocol to http:// #3977

Merged
merged 1 commit into from
Sep 14, 2016

Conversation

ayumi
Copy link
Contributor

@ayumi ayumi commented Sep 14, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #3751

This isn't an ideal solution, but it bandaids #3751 such that publisher links on the Payments page always work.
In the future we might revisit the intermittently missing ledgerInfo favicon / protocol.

Auditors: @mrose17

Test Plan:

  1. Browse various websites for >8s each
  2. Check Preferences -> Payments and confirm that favicon-less publisher links work

Fix #3751

Auditors: @jkup @mrose17

Test Plan:

1. Browse various websites for >8s each
2. Check Preferences -> Payments and confirm that favicon-less publisher links work
@ayumi ayumi merged commit 770ddce into master Sep 14, 2016
@ayumi ayumi deleted the fix/ledger-publishers-no-favicon-links branch September 14, 2016 00:19
@luixxiul luixxiul added this to the 0.12.1dev milestone Sep 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants