This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
sortabletable fixes, make ledger table sortable #4057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #4047 minor UI improvements
diracdeltas
commented
Sep 16, 2016
| </tbody> | ||
| </table> | ||
| } | ||
| } | ||
|
|
||
| SortableTable.defaultProps = { |
There was a problem hiding this comment.
i took this out because no other components use defaultProps
bsclifton
reviewed
Sep 16, 2016
| entry.get('lastAccessedTime') | ||
| ? new Date(entry.get('lastAccessedTime')).toLocaleTimeString() | ||
| : '', | ||
| { |
|
Pulled it locally and tested- confirmed it's working good. Spacing seems to be a little different with the ledger screen, but still looks great. Great job 😄 |
This was referenced Sep 22, 2016
This was referenced Sep 22, 2016
This was referenced Sep 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fix #4047
FIx #4046
Also refactors SortableTable for performance
Test Plan:
Auditors: @bsclifton