Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

bookmarks toolbar still not fully filling up on some resolutions #4116

Closed
bbondy opened this issue Sep 19, 2016 · 3 comments
Closed

bookmarks toolbar still not fully filling up on some resolutions #4116

bbondy opened this issue Sep 19, 2016 · 3 comments

Comments

@bbondy
Copy link
Member

bbondy commented Sep 19, 2016

I think it depends on the DPI setting, my wife's laptop doesn't fill up the whole toolbar though.

#9939

@jonathansampson
Copy link
Collaborator

jonathansampson commented Aug 19, 2017

@bbondy Does this still repro on your wife's laptop? If so, can you share its specs here? I spoke with a user recently who saw the same behavior: #10594

@bbondy
Copy link
Member Author

bbondy commented Aug 23, 2017

This issue is very old, we still have problems but now with it being too full. I think nejc's changes should solve it finally hopefully.

@bbondy bbondy closed this as completed Aug 23, 2017
@bbondy bbondy removed this from the 1.0.0 milestone Aug 23, 2017
@cezaraugusto
Copy link
Contributor

I think Nejc's PR just moves the current calculation to the state and is more perf-related. This issue was duplicated at least two times and was supposed to be fixed in #9664 but still needs improvements.

Calculation is still not at its best ATM but will be eventually after checking for element intersection in bm toolbar which is a method I'm still introducing.

I'm tracking it in a similar issue: #9939

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants