Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Media queries for elements inside #urlInput need improving #4170

Closed
luixxiul opened this issue Sep 22, 2016 · 1 comment
Closed

Media queries for elements inside #urlInput need improving #4170

luixxiul opened this issue Sep 22, 2016 · 1 comment

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 22, 2016

Describe the issue you encountered:

clipboard01

Expected behavior: Media queries for elements inside #urlInput need improving. It seems to me that we do not need max-width here at all. Here is my suggestion:

  • Set width: 135px to .WindowCaptionButtons, which seems to be static (correct if I'm wrong)
  • Set width: calc(100% - 135px) to .navbarMenubarFlexContainer
  • Remove max-width properties based on platforms from #urlInput

By doing these we should get this:
menubar

@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label Sep 22, 2016
@luixxiul luixxiul added this to the 0.12.2dev milestone Sep 22, 2016
@luixxiul luixxiul added feature/titlebar and removed design A design change, especially one which needs input from the design team. labels Sep 22, 2016
@luixxiul luixxiul modified the milestones: 0.12.3dev, 0.12.2dev Sep 22, 2016
@luixxiul luixxiul changed the title Media queries for #urlInput needs improving Media queries for elements inside #urlInput need improving Sep 22, 2016
@luixxiul luixxiul modified the milestones: 0.12.2dev, 0.12.3dev Sep 25, 2016
@jonathansampson
Copy link
Collaborator

All that is really needed is to set the input element's width to 100%.

I have this change in a commit, and will issue a PR.

resize-mq-fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants