Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make autofill be tab modal and not window modal #4266

Closed
luixxiul opened this issue Sep 24, 2016 · 3 comments
Closed

Make autofill be tab modal and not window modal #4266

luixxiul opened this issue Sep 24, 2016 · 3 comments
Labels
feature/autofill priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). stale suggestion

Comments

@luixxiul
Copy link
Contributor

Expected behavior: Modal window on about:autofill should not be closed with a mouse click on the outside of the window.

  • Platform (Win7, 8, 10? macOS? Linux distro?): OS X
  • Brave Version: 0.12.2 RC3
  • Steps to reproduce:
    1. Click add address on about:autofill
    2. Fill some data in a modal window
    3. Click on the outside of the modal window
    4. The data is cleared
  • Any related issues:
@bbondy
Copy link
Member

bbondy commented Sep 24, 2016

I think that is expected for all of our modal windows if you click outside of them. Let me know if you strongly disagree but I'll close this as wontfix for now.

@bbondy bbondy closed this as completed Sep 24, 2016
@luixxiul
Copy link
Contributor Author

I just assume there would be some users disappointed if they filled data and saw the data lost by clicking/tapping the outside of the modal window unintentionally.

@bbondy bbondy reopened this Sep 25, 2016
@bbondy bbondy removed the wontfix label Sep 25, 2016
@bbondy bbondy changed the title Modal window on about:autofill should not be closed with a mouse click Make autofill be tab modal and not window modal Sep 25, 2016
@bbondy
Copy link
Member

bbondy commented Sep 25, 2016

I re-opened but updated to be tab modal instead of window modal. The use case is for example a user wants to lookup information to fill it in in another tab. This isn't high prior though.

#7107

@luixxiul luixxiul added this to the Backlog milestone Feb 5, 2017
@bbondy bbondy removed this from the Backlog milestone Oct 19, 2017
@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@bsclifton bsclifton modified the milestones: Triage Backlog, Prioritized Backlog Nov 21, 2017
@bsclifton bsclifton added priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). and removed priority/low (deprecated) labels Nov 22, 2017
@bsclifton bsclifton added the stale label Aug 7, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Aug 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/autofill priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). stale suggestion
Projects
None yet
Development

No branches or pull requests

4 participants