Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ledger server is configurable by ENV variable "LEDGER_SERVER_URL" #4297

Merged
merged 1 commit into from
Oct 16, 2016
Merged

Ledger server is configurable by ENV variable "LEDGER_SERVER_URL" #4297

merged 1 commit into from
Oct 16, 2016

Conversation

willy-b
Copy link
Contributor

@willy-b willy-b commented Sep 25, 2016

  • Submitted a ticket for my issue if one did not already exist

This supports #4286 (since this makes it easy to point Brave to a Ledger server using Bitcoin testnet)

@willy-b
Copy link
Contributor Author

willy-b commented Sep 30, 2016

Test plan:

  1. Clear local Ledger data
  2. Check in browser if my unreliable testnet Ledger server is available: http://ledger-testnet.entropi.info/documentation
  3. If it is, run Brave with `LEDGER_SERVER_URL=http://ledger-testnet.entropi.info'
  4. Open Preferences->Payments
  5. Confirm Wallet can be created
  6. Grab wallet address (from Add Funds)
  7. Visit a testnet faucet (https://testnet.manu.backend.hamburg/faucet)
  8. Confirm testnet bitcoin can be transferred to address

for #4286

@mrose17
Copy link
Member

mrose17 commented Oct 16, 2016

lgtm.

@willy-b
Copy link
Contributor Author

willy-b commented Oct 16, 2016

thanks for the review+merge @mrose17!

@luixxiul luixxiul added this to the 0.12.5dev milestone Oct 17, 2016
@alexwykoff alexwykoff mentioned this pull request Oct 18, 2016
102 tasks
@luixxiul
Copy link
Contributor

luixxiul commented Oct 18, 2016

I am testing it out and it looks working well. I had to delete the local ledger-* files at first (as mentioned in the post above).

@willy-b it would be nice if it becomes possible to avoid the 30 min waiting time and funds are added instantly.

screenshot 2016-10-19 0 06 29

@luixxiul luixxiul modified the milestones: 0.12.6dev, 0.12.5dev Oct 18, 2016
@luixxiul
Copy link
Contributor

Though the wallet became ready, some kind of error is happening.

screenshot 2016-10-19 0 46 20

@luixxiul
Copy link
Contributor

Nevermind, I just restarted brave without the env. it works now 👍

screenshot 2016-10-19 0 50 25

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants