Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adds rounded borders to the top corners for Windows 7 #4342

Merged
merged 1 commit into from
Oct 4, 2016
Merged

Adds rounded borders to the top corners for Windows 7 #4342

merged 1 commit into from
Oct 4, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Adds rounded borders to the top corners for Windows 7
screen shot 2016-09-27 at 6 06 05 pm

  • Introduces a platformUtil helper
  • Top level element uses this helper to add classes for platform and release (Windows only)
  • removed OS detection logic in WindowCaptionButtons component
  • reworked styles in navigationBar.less

Manually tested on:

  • Windows 7
  • Windows 10
  • Windows 7 at 150% DPI (corners didn't look exactly right, but might be a VM issue)

Fixes #4216

Auditors: @bbondy @bridiver

- Introduces a platformUtil helper
- Top level element uses this helper to add classes for platform and release (Windows only)
- removed OS detection logic in WindowCaptionButtons component
- reworked styles in navigationBar.less

Fixes #4216

Auditors: @bbondy @bridiver
@bsclifton bsclifton added this to the 0.12.4dev milestone Sep 28, 2016
@bsclifton
Copy link
Member Author

There are two methods in platformUtil which are not used: isDarwin and isWindows. I was thinking maybe these could be used in place of all the const isDarwin = process.platform === 'darwin' calls we have (but felt it was out of scope for this change)

@bbondy
Copy link
Member

bbondy commented Oct 4, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants