Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added tear off tabs - Ability to drag tab into new window #4402

Closed
lucidNTR opened this issue Sep 30, 2016 · 25 comments
Closed

Added tear off tabs - Ability to drag tab into new window #4402

lucidNTR opened this issue Sep 30, 2016 · 25 comments
Assignees
Milestone

Comments

@lucidNTR
Copy link
Contributor

lucidNTR commented Sep 30, 2016

Did you search for similar issues before submitting this one?
yes

Describe the issue you encountered:
if i want to have a new window for a tab other browsers allow dragging a tab out of the window to create a new window. i expect the same behaviour in brave.

Expected behavior:
see above

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macos
  • Brave Version:
    master

Steps to test: (edited in by bbondy)

  • Drag last tab from a window into an existing other window
  • Drag a tab out of an existing window, not last tab.
  • Use context menu on tab to detach
  • Make sure pinned tab can't be dragged out
  • Make sure detach item doesn't appear on pinned tab
  • Make sure no detach context menu on tab if it's the last tab.
  • Test pinned tabs fully that they work as expected.
@getsetbro
Copy link
Contributor

Also dragging a tab from one open window to another open window should move it to the opened window that it was dragged to. Currently it does not move it (tested on Mac El Capitan version 10.11.6).

@cndouglas cndouglas added the parity Features which should be supported in Brave since they're supported in other major browsers. label Nov 16, 2016
@cndouglas
Copy link

cndouglas commented Nov 16, 2016

Not to be confused with #405. This issue refers to creating a new window with an existing tab (still in the same Brave process).
Edit: Actually, #405 is a duplicate of this.

@echosa
Copy link
Contributor

echosa commented Nov 16, 2016

Additionally, I would expect there to be a right-click menu option for "Move To New Window" when right-clicking tabs.

@cndouglas
Copy link

This is an essential feature every major browser has. I'll set the milestone to 1.0 for now. Please change/remove the milestone if needed.

@cndouglas cndouglas added this to the 1.0.0 milestone Nov 20, 2016
@srirambv
Copy link
Collaborator

+1 from support

@srirambv
Copy link
Collaborator

+1 from support

@outragedhuman
Copy link

+1 essential feature

@luixxiul
Copy link
Contributor

luixxiul commented Jan 4, 2017

@yannduran
Copy link

👍

@bsclifton bsclifton changed the title dragging tab into new window Ability to drag tab into new window ("tear off" tabs) Jan 20, 2017
@CliqueBait
Copy link

@ryanleesipes
Copy link

Just adding another supporting comment for this feature. I'm excited to see this make it in. Are there any branches/anyone currently working on this?

@NejcZdovc
Copy link
Contributor

You can see progress here #6929

@ivanstegic
Copy link

This is currently a deal breaker for me: I didn't realize how much I sort and rearrange tabs until I couldn't do it. Looking forward to the feature being added!

@amc2002
Copy link

amc2002 commented Mar 1, 2017

Deal breaker here too. I love Brave, but rearranging tabs and breaking them off to new windows is essential. Had to go back to Firefox. :(

@echosa
Copy link
Contributor

echosa commented Mar 1, 2017

Agreed. I've been keeping a list of issues with Brave that will make me switch back to another browser if not fixed. This is one of the (currently) 10 items on that list.

@ivanstegic
Copy link

@echosa what are the other items? Do you have them listed somewhere, I'd love to see them!

@echosa
Copy link
Contributor

echosa commented Mar 1, 2017

Well, I did just have this as some terse notes in a private Fastmail note. Then you had to go and ask for it publicly, so I had to write out some better descriptions, and go aggregate all the links to the appropriate GitHub issues. :-P

So, here you go: https://gist.github.com/echosa/ed4a150d74e96fc6d54b72a8ae853a61

@ivanstegic
Copy link

Thank you good sir, starred the list. Some of those are annoyances for me, but not deal breakers... like the YouTube ads one. If this was reddit, I'd gold you.

@echosa
Copy link
Contributor

echosa commented Mar 1, 2017

Indeed. There's a reason the ads issues are so far down the list. I suppose I could break the list into "must haves" and "nice to haves", but meh. It's fine as is for now.

Enough side-tracking this issue, though. :-)

@bsclifton
Copy link
Member

Thanks for sharing the list, @echosa 😄

@echosa
Copy link
Contributor

echosa commented Mar 1, 2017

:-) I'm really trying to stay on Brave as default, but these things are making it difficult. I consider switching away, then switching back when Brave meets more of my requirements. :-P I love Brave. I love the idea of it. I enjoy using it (when it does what I need). However, if there's already a browser out there that meets my needs, it's difficult to turn it away. I'm trying, though. That's for sure.

@jonathansampson
Copy link
Collaborator

@bsclifton bsclifton modified the milestones: 0.14.2, 1.0.0 Apr 7, 2017
@bbondy
Copy link
Member

bbondy commented Apr 10, 2017

Done, finally!
#8084

@bbondy bbondy closed this as completed Apr 10, 2017
@luixxiul
Copy link
Contributor

@bbondy would you mind adding QA steps if any? Thanks! :-)

@bbondy
Copy link
Member

bbondy commented Apr 13, 2017

I edited in steps to test in the first comment @luixxiul

@alexwykoff alexwykoff changed the title Ability to drag tab into new window ("tear off" tabs) Added tear off tabs Apr 13, 2017
@luixxiul luixxiul changed the title Added tear off tabs Added tear off tabs - Ability to drag tab into new window Apr 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests