Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Offer the user a way to opt-out of crash reporting #4479

Closed
bsclifton opened this issue Oct 3, 2016 · 2 comments
Closed

Offer the user a way to opt-out of crash reporting #4479

bsclifton opened this issue Oct 3, 2016 · 2 comments

Comments

@bsclifton
Copy link
Member

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
We use electron's crash reporting code to collect data about crashes that occur (which do not contain personally identifiable information (PII)). Not all users are OK with this and would like a way to opt-out.

This could be offered during installation and/or as a preference

Expected behavior:
When a crash occurs, no information is transmitted.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    all
  • Brave Version:
    all (current version is 0.12.3)
@bbondy
Copy link
Member

bbondy commented Oct 4, 2016

@aekeus would you mind taking this one? We need to have it for 1.0. The switch control can go into preferences in advanced section under Enable smooth scrolling.

smooth scrolling is one of those things in app/index.js that you have to set early on or it has no effect. I think you can init crash-herald alongside it, just search for disable-smooth-scrolling in app/index.js.

I'd like you to take this because you can best make sure we are still getting crash reports still.

bbondy referenced this issue Oct 4, 2016
improved handling for exceptions inside promises
related #4477
auditors: @bbondy @bsclifton
@aekeus aekeus self-assigned this Oct 4, 2016
@aekeus
Copy link
Member

aekeus commented Oct 7, 2016

Fixed with pull request #4606

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants