Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bravery button should be inside the tabs area #4591

Closed
bsclifton opened this issue Oct 6, 2016 · 7 comments
Closed

Bravery button should be inside the tabs area #4591

bsclifton opened this issue Oct 6, 2016 · 7 comments
Assignees
Labels
design A design change, especially one which needs input from the design team. feature/titlebar

Comments

@bsclifton
Copy link
Member

bsclifton commented Oct 6, 2016

Bravery button should be moved into the tabs area. Here are the current mockups for Windows

Win 10
image

Win 7
image

Mac
image

@bsclifton bsclifton added design A design change, especially one which needs input from the design team. feature/titlebar labels Oct 6, 2016
@bsclifton bsclifton added this to the 0.12.5dev milestone Oct 6, 2016
@neeklamy
Copy link
Contributor

neeklamy commented Oct 7, 2016

What’s the distinction between a button living in the tabs area versus the title bar? And why does the Brave button move down, but the password manager (if it’s configured) stays in the title bar?

I’d suggest the only things that should be in the tabs area, are tab related.

It looks like anyone using Windows (and Windows 10 especially so on smaller screens) will have less space to grab and move the window around too.

This change seems arbitrary, that lovely lion logo looks great up in the top right corner, with it there, there really can’t be any question over which web browser we’re looking at.

@privatzee
Copy link
Contributor

Well, I think that's a mistake. It'll tend to get lost down on the tab bar -- most especially as far as brand new users go. Moving it would also make the browser less distinctive at first look. You've only got one chance to make a first impression.

Also, the less confusion the better. So again for brand new users, it's very handy to say in any doc: "click the lion in the upper right" and it does stand out more where it is.

@bsclifton
Copy link
Member Author

Here's a quick mock-up I did of something @bradleyrichter and I had talked about on Friday. Basically, it would be moving the lion head / extension buttons over to opposite side of the caption buttons. This is fairly close to Mac

cc: @neeklamy @privatzee

Proposed Windows look
screen shot 2016-10-10 at 1 59 03 am

Current look on Mac
screen shot 2016-10-10 at 2 02 20 am

@srirambv
Copy link
Collaborator

@bsclifton Personally not a big fan of having things before the back/forward buttons. But the new renders look much better than having the Lion icon in place of the hamburger menu. One alternate could be moving it next to the current bookmarks icon position(once this is moved inside the URL bar). This way the Lion doesn't move up and down when the menu is selected(current behavior) and can still be selected when mouse hovers over URL bar(irrespective of being in title mode or URL mode).

@bbondy bbondy modified the milestones: 0.12.6dev, 0.12.5dev Oct 10, 2016
@bsclifton
Copy link
Member Author

@bradleyrichter not sure if you had an update or needed more time. I definitely won't have time before Monday to look at this though ☹️ Should we move this back a sprint or two?

@neeklamy
Copy link
Contributor

@bsclifton, that definitely looks nicer, it’s a shame that positioning the Brave lion consistently across platforms is so difficult (impossible?). Being able to say to someone new to the browser “top right” or “top left” would be a big win.

The only cross platform example I can think of by way of comparison would be iTunes. But, as a representative set of “1” and someone who really, really appreciates applications being consistent to the platform standards (OS X/macOS makes you that way), I wonder would you consider diddling with the “traffic lights” on the Mac version? Something like Apple briefly played with in iTunes:

iTunes 9 v 10 comparison

(From: What happened to the iTunes 10 window controls?)

Doing that would enable you to place the Brave lion up in the top left corner on all platforms.

@bsclifton bsclifton modified the milestones: 0.12.7dev, 0.12.6dev Oct 17, 2016
@bradleyrichter
Copy link
Contributor

closing this as we decided to leave the Brave button on the upper right. Thanks all for the input.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/titlebar
Projects
None yet
Development

No branches or pull requests

6 participants