Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

titlebar became narrow a little on Windows #4622

Closed
luixxiul opened this issue Oct 8, 2016 · 5 comments
Closed

titlebar became narrow a little on Windows #4622

luixxiul opened this issue Oct 8, 2016 · 5 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 8, 2016

Describe the issue you encountered:

clipboard01

Expected behavior: I am not sure if it was intentional. @bsclifton will tell :-D

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.4
  • Any related issues:
@bsclifton
Copy link
Member

This was intentionally removed w/ 2f25023

It previously had:

  • 5px padding to the left of nav buttons / File menu
  • 5px on top, above menu

The padding on top was causing issues after accepting #4400 and also contributed to #4539 (making it worse).

Here's a screenshot of Firefox that I used as inspiration when testing out removing the removal of padding:
screen shot 2016-10-08 at 12 28 36 am

for a side-by-side, here's a shot of Brave:
image

Does the change look bad? @luixxiul, @bradleyrichter, let me know what you think 😄

@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 8, 2016

I'm for it 👍

@bigkitttty
Copy link

I'm not for it.

@bsclifton
Copy link
Member

@bigkitttty what don't you like about it? Do you prefer having the standard Windows titlebar?

@bsclifton
Copy link
Member

Closing this issue for now... if you'd like to see a different look, please re-open, leave a comment with your preferred look, and cc myself or Brad on it 😄 Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants