Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix bookmark clipping #4636

Merged
merged 1 commit into from
Oct 11, 2016
Merged

Fix bookmark clipping #4636

merged 1 commit into from
Oct 11, 2016

Conversation

cndouglas
Copy link

@cndouglas cndouglas commented Oct 8, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  1. Create a bookmark for any page.
  2. Set the title to q y p g j.
  3. Make sure the letters are not clipped at the bottom.

Fixes #4614

@@ -44,7 +44,7 @@
color: black;
cursor: default;
font-size: 11px;
line-height: 11px;
line-height: 14px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great when bookmark toolbar icons is turned on but when there is not it throws off the vertical alignment a lot. Could you fix? Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try the new commit (d289f1a).

@cndouglas
Copy link
Author

I decided to reduce the line height of the bookmark button and increase the toolbar height. I hope this is the right approach.

@bbondy
Copy link
Member

bbondy commented Oct 11, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants