Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Extension API: chrome.windows.onFocusChanged #4760

Closed
3 tasks
jonathansampson opened this issue Oct 14, 2016 · 9 comments
Closed
3 tasks

Extension API: chrome.windows.onFocusChanged #4760

jonathansampson opened this issue Oct 14, 2016 · 9 comments

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Oct 14, 2016

https://developer.chrome.com/extensions/windows#event-onFocusChanged

  • chrome.windows.onFocusChanged.addListener(listener)

An addListener method exists, but does not appear to call the handler.

  • chrome.windows.onFocusChanged.removeListener(listener)
  • chrome.windows.onFocusChanged.hasListener(listener)
@jonathansampson jonathansampson changed the title Evernote: chrome.windows.onFocusChanged not supported Extension APIs: chrome.windows.onFocusChanged Apr 14, 2017
@jonathansampson
Copy link
Collaborator Author

jonathansampson commented Apr 19, 2017

Blocks #8327, #9531, #9828

@kspearrin
Copy link
Contributor

Any priority or timeline behind this issue being resolved?

@jonathansampson
Copy link
Collaborator Author

@kspearrin We merged a few commits that added support. Just need to build and test one last time to confirm that all is working properly.

Should be able to close in a few hours (assuming all goes as planned).

@kspearrin
Copy link
Contributor

Any update @jonathansampson?

@jonathansampson
Copy link
Collaborator Author

Closed by brave/muon#180

@jonathansampson
Copy link
Collaborator Author

Reopening as hasListener and removeListener should also be supported.

@bsclifton bsclifton removed this from the 0.15.300 milestone May 12, 2017
@bsclifton
Copy link
Member

bsclifton commented May 12, 2017

removing from 0.15.300 since there's more work to be done

@jonathansampson @cezaraugusto does this affect the Bitwarden extension? Cezar, I saw you merged the enabling of Bitwarden in the UI today... did you get a chance to test?

@kspearrin
Copy link
Contributor

@bsclifton bitwarden does not use removeListener or removeListener directly, so it should not be a problem unless it is indirectly invoked by something else.

@jonathansampson jonathansampson changed the title Extension APIs: chrome.windows.onFocusChanged Extension API: chrome.windows.onFocusChanged Jul 2, 2017
@jonathansampson jonathansampson mentioned this issue Jul 2, 2017
30 tasks
@jonathansampson
Copy link
Collaborator Author

I'm going to close this for now, since our support matches the Chrome documentation. If there appears a need to re-open in the future (for hasListener, and removeListener) we can re-open.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants