Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Changing language should prompt to restart #4777

Closed
bbondy opened this issue Oct 14, 2016 · 2 comments
Closed

Changing language should prompt to restart #4777

bbondy opened this issue Oct 14, 2016 · 2 comments
Labels
bug/good-first-bug l10n QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@bbondy
Copy link
Member

bbondy commented Oct 14, 2016

Currently when you change the language in preferences it doesn't take effect right away but also doesn't prompt to restart for the change to take effect. We should prompt like we do for the other settings.

STR:

  1. Go to about:preferences
  2. Change the default language

Actual results:
No Prompt to restart

Expected results:
Notification bar to restart like the one in advanced -> hardware acceleration
@bbondy bbondy mentioned this issue Oct 14, 2016
Closed
@luixxiul luixxiul added the l10n label Oct 14, 2016
@luixxiul
Copy link
Contributor

Note: the fix on this should close #4749 and #1705 too.

@luixxiul luixxiul added this to the contributor backlog milestone Dec 23, 2016
This was referenced Dec 24, 2016
Closed
Merged
@luixxiul luixxiul removed this from the contributor backlog milestone Dec 24, 2016
@bbondy bbondy added this to the 0.13.0 milestone Dec 30, 2016
This was referenced Dec 30, 2016
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor

Test plan: available on the 1st post.

@srirambv srirambv mentioned this issue Jan 20, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug/good-first-bug l10n QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
3 participants
@bbondy @luixxiul @srirambv