Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Capture javascript stack trace in crash reports #4799

Closed
bridiver opened this issue Oct 14, 2016 · 1 comment
Closed

Capture javascript stack trace in crash reports #4799

bridiver opened this issue Oct 14, 2016 · 1 comment
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x Hotfix 13 ...

Comments

@bridiver
Copy link
Collaborator

bridiver commented Oct 14, 2016 •
edited by bsclifton
Loading

Test plan

  1. Login to stats.brave.com
  2. On the left, pick Recent Crashes
  3. Open a report
  4. Verify that the javascript-info field is populated and has a stack trace

Original issue description

We currently don't receive any useful information about the javascript stack when a crash is caused by JS code inside a native callback. We should catch these exceptions, use crash keys to capture the JS stack and re-throw them to be handled by the crash reporter.
@alexwykoff alexwykoff added this to the 1.0.1 milestone Nov 9, 2016
@alexwykoff alexwykoff modified the milestones: 1.0.1, Backlog Nov 1, 2017
@bridiver
Copy link
Collaborator Author

closed by 39bd844#diff-6d8628df937f9c42db1b0e451b4afdbe

@luixxiul luixxiul modified the milestones: Triage Backlog, 0.19.x Hotfix 13 Jan 15, 2018
This was referenced Jan 18, 2018
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x Hotfix 13 (Release Channel)
Development

No branches or pull requests
7 participants
@bridiver @alexwykoff @kjozwiak @luixxiul @bsclifton @srirambv @LaurenWags