Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Advanced settings button should be hidden when Brave Payments are off #4826

Closed
charbelrami opened this issue Oct 15, 2016 · 1 comment
Closed

Advanced settings button should be hidden when Brave Payments are off #4826

charbelrami opened this issue Oct 15, 2016 · 1 comment
Labels
design A design change, especially one which needs input from the design team. duplicate Issue has already been reported

Comments

@charbelrami
Copy link
Contributor

charbelrami commented Oct 15, 2016 •
edited
Loading

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Advanced settings button doesn't do anything if the Brave Payment switch is off

Expected behavior:
Hide or disable the button when the switch is off

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Win 10 64-bit
  • Brave Version:
    v0.12.5dev-RC1
  • Steps to reproduce:

    1. Preferences

    2. Click advanced settings
  • Screenshot if needed:
    advanced-settings-btn
  • Any related issues:
@charbelrami charbelrami added the design A design change, especially one which needs input from the design team. label Oct 15, 2016
@Sh1d0w
Copy link

Sh1d0w commented Oct 15, 2016 •
edited
Loading

Duplciate of #4790

@Sh1d0w Sh1d0w closed this as completed Oct 15, 2016
@luixxiul luixxiul added the duplicate Issue has already been reported label Oct 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team. duplicate Issue has already been reported
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@luixxiul @Sh1d0w @charbelrami