Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

convert toolbar icons to SVG #4852

Closed
bradleyrichter opened this issue Oct 17, 2016 · 7 comments
Closed

convert toolbar icons to SVG #4852

bradleyrichter opened this issue Oct 17, 2016 · 7 comments
Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.9dev

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Oct 17, 2016 •
edited
Loading

To create a uniform icon set, we need to switch to SVG icons. (FA icons for Home and stop-loading don't work with the rest of our icon styles.)

image

image

toolbar_svgs.zip

@jkup Perhaps we could add this to #4829 ?
@bradleyrichter bradleyrichter added enhancement design A design change, especially one which needs input from the design team. labels Oct 17, 2016
@bradleyrichter bradleyrichter added this to the 0.12.6dev milestone Oct 17, 2016
@bsclifton bsclifton mentioned this issue Oct 17, 2016
Closed
@bradleyrichter
Copy link
Contributor Author

@bsclifton ^^

@bsclifton bsclifton self-assigned this Oct 17, 2016
@bsclifton
Copy link
Member

@jkup I've started to pull these in. They're in a branch in my fork, being added to fix #4684

@bsclifton bsclifton mentioned this issue Oct 18, 2016
Merged
@bsclifton bsclifton removed their assignment Oct 18, 2016
@bsclifton
Copy link
Member

Added images for all and styles for new bookmark & new bookmark folder with #4878

@jkup jkup modified the milestones: 0.12.7dev, 0.12.6dev Oct 18, 2016
@jkup
Copy link
Contributor

jkup commented Oct 18, 2016

I'm bumping this for now but am going to put up a WiP PR for now.

This was referenced Oct 18, 2016
Closed
Closed
Merged
@bbondy
Copy link
Member

bbondy commented Oct 25, 2016 •
edited
Loading

Toolbar seems to be a mess so had to revert the PR:
screenshot 2016-10-24 21 45 30

@bbondy
Copy link
Member

bbondy commented Oct 25, 2016

moving to 0.12.8

@bbondy bbondy modified the milestones: 0.12.8dev, 0.12.7dev Oct 25, 2016
@bbondy bbondy reopened this Oct 25, 2016
This was referenced Oct 27, 2016
Closed
Merged
@bbondy bbondy modified the milestones: 0.12.9dev, 0.12.8dev Oct 27, 2016
@luixxiul luixxiul mentioned this issue Nov 7, 2016
Closed
This was referenced Nov 10, 2016
Closed
Closed
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Nov 14, 2016
Closed
@luixxiul
Copy link
Contributor

luixxiul commented Nov 21, 2016 •
edited
Loading

Have we integrated an optimization tool like https://github.com/svg/svgo already?

@luixxiul luixxiul mentioned this issue Nov 21, 2016
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.9dev
Development

Successfully merging a pull request may close this issue.

[WiP] convert toolbar icons to svg brave/browser-laptop
7 participants
@jkup @bbondy @alexwykoff @luixxiul @bsclifton @bradleyrichter @srirambv