Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add bookmark folder modal width changes when a long folder name is added #4864

Closed
srirambv opened this issue Oct 17, 2016 · 4 comments
Closed

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?

Describe the issue you encountered:
Add bookmark folder modal width changes when a long folder name is added

Expected behavior:
Should remain same

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All
  • Brave Version:
    0.12.5 RC3
  • Steps to reproduce:
    1. Create a bookmark folder via the bookmark toolbar
    2. Enter unusually long name for the folder and save it
    3. Try creating a new folder from bookmark toolbar, shows big modal than the standard modal
  • Screenshot if needed:
    image
  • Any related issues:
@srirambv srirambv added this to the 0.12.6dev milestone Oct 17, 2016
@srirambv
Copy link
Collaborator Author

cc: @jkup

@luixxiul
Copy link
Contributor

I noticed it too but not quite sure how to fix it and whether it should be fixed.

@jkup
Copy link
Contributor

jkup commented Oct 17, 2016

Yeah same, we could fix it by adding a max-width but should we?

cc @bradleyrichter

@jkup jkup self-assigned this Oct 17, 2016
@bradleyrichter
Copy link
Contributor

Just because you "can" use 256 characters doesn't mean you should. ; 0

Let's set it as a fixed width field in the new dialog and not spend time on the old.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants