UrlBar autocomplete feels broken and is not reliable

[Sh1d0w]

Did you search for similar issues before submitting this one?

Yes.

Describe the issue you encountered:
UrlBar autocomplete is not working reliably. Sometimes it offers suggestions after you type 3, 4 or more letters, without matching any of the entries in the history.

In the following video I demonstrate PoC with http://twitter.com - a website that I often visit. I should get suggestions as soon as I type t or even tw. In the current version of Brave this happens only if I type twi ... : http://webm.land/media/HanC.webm

There are cases for some websites that I have to type 5 of the letters of the domain I want to visit in order to get autocomplete suggestions...

Expected behavior:
Autocomplete should start as soon as you type and deliver relevent suggestions not matter how much letters you type in the url bar.

• Platform (Win7, 8, 10? macOS? Linux distro?): All
• Brave Version: 0.12.5-RC2
• Steps to reproduce:
  1. Open new tab
  2. Start typing a website you often visit
• Screenshot if needed:
  Video of the issue: http://webm.land/media/HanC.webm
• Any related issues:
  Start suggestions after first character not second fixes #3235 #3238
  UrlbarSuggestions does not work if you are offline #4821

[Sh1d0w]

This is fixed now. Closing.

[alexwykoff]

@Sh1d0w do you know where the fix landed? Is it in 0.12.6 or 0.12.7? Thanks

[Sh1d0w]

It is fixed by this commit 3468b09 , but since I am building fresh installs from master each day I can't really tell if it was included in 0.12.6 .

I see some of the tickets are marked as fixed are in 0.12.6, some are in 0.12.7.

[alexwykoff]

I see the commit has been tagged for 0.12.7 so I'm adding it to the milestone.