Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark Icon position in title mode looks bad #4985

Closed
srirambv opened this issue Oct 20, 2016 · 5 comments
Closed

Bookmark Icon position in title mode looks bad #4985

srirambv opened this issue Oct 20, 2016 · 5 comments
Assignees
@jkup
Labels
design A design change, especially one which needs input from the design team. feature/titlebar QA/checked-Linux QA/checked-macOS QA/checked-Win64 suggestion
Milestone
0.12.6dev

Comments

@srirambv
Copy link
Collaborator

Bookmark Icon position in title mode looks bad

image

Should be more like
image

cc: @bradleyrichter @jkup
@srirambv srirambv added design A design change, especially one which needs input from the design team. suggestion feature/titlebar labels Oct 20, 2016
@srirambv srirambv added this to the 0.12.6dev milestone Oct 20, 2016
@jkup jkup self-assigned this Oct 20, 2016
@bradleyrichter
Copy link
Contributor

@srirambv is correct. This is a visual big.

@bbondy
Copy link
Member

bbondy commented Oct 21, 2016

regression?

@srirambv
Copy link
Collaborator Author

In 0.12.5 title mode, bookmark icon was not shown. This is new feature for showing the bookmark icon in this release

@jkup
Copy link
Contributor

jkup commented Oct 21, 2016

Yeah it's not a regression I just didn't see a spec for how it should look now that we show the icon! Fixing for 12.6.

@bradleyrichter
Copy link
Contributor

I need a prototype soldier to try left-aligned elements. Until then, lets keep the star hidden in title mode.

@jkup jkup mentioned this issue Oct 21, 2016
Merged
4 tasks
This was referenced Oct 22, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jkup jkup

Labels
design A design change, especially one which needs input from the design team. feature/titlebar QA/checked-Linux QA/checked-macOS QA/checked-Win64 suggestion
Projects
None yet
Milestone
0.12.6dev
Development

No branches or pull requests
5 participants
@jkup @bbondy @alexwykoff @bradleyrichter @srirambv