Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Reimporting bookmarks after generating favicons still doesn't create it on Brave #4999

Closed
srirambv opened this issue Oct 20, 2016 · 1 comment

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Reimporting bookmarks after generating favicons still doesn't create it on Brave

Expected behavior:
Should recreate favicons after re-import

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.6 Preview 1
  • Steps to reproduce:
    1. Manually create a bookmark on Chrome, Has a blank icon
    2. Import bookmarks from Chrome, Has the same blank icon
    3. Open the bookmarked link in step 1 on Chrome, Updates the favicon
    4. Reimport the bookmarks from Chrome, favicon doesn't update on Brave still remains blank
  • Screenshot if needed:
    importfavicons
  • Any related issues:
    4882

cc: @darkdh

@darkdh
Copy link
Member

darkdh commented Oct 20, 2016

@srirambv , you need to close Chrome before importing because the Favicon database is locked by it.
Maybe filing another issue to prompt a popup window telling people to close Chrome before importing.

@darkdh darkdh closed this as completed Oct 20, 2016
@darkdh darkdh removed this from the 0.12.7dev milestone Oct 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants