Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

tab bar and find bar unaligned #5005

Closed
luixxiul opened this issue Oct 20, 2016 · 5 comments
Closed

tab bar and find bar unaligned #5005

luixxiul opened this issue Oct 20, 2016 · 5 comments
Labels
design A design change, especially one which needs input from the design team. feature/findbar QA/checked-Linux QA/checked-macOS QA/checked-Win64
Milestone
0.12.6dev

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered:

screenshot 2016-10-21 1 15 16

- Platform (Win7, 8, 10? macOS? Linux distro?): OS X - Brave Version: master branch - Any related issues:
@luixxiul luixxiul added design A design change, especially one which needs input from the design team. feature/findbar bug/good-first-bug labels Oct 20, 2016
@luixxiul
Copy link
Contributor Author

actually this is the tab bar height issue.

screenshot 2016-10-21 12 02 09

@luixxiul luixxiul changed the title height of findbar close button tab bar and find bar unaligned Oct 21, 2016
@bsclifton
Copy link
Member

I'm curious if this was accidentally introduced with #4829?

@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 21, 2016 •
edited
Loading

^^ also the border-bottom under the active tab should be removed.

@bradleyrichter bradleyrichter added this to the 0.12.6dev milestone Oct 22, 2016
@bradleyrichter
Copy link
Contributor

@bsclifton this could have been my blunder.

It's only visible when the find bar is open. I don't have a fix. Perhaps you have an idea.

image

@bbondy bbondy closed this as completed in 1e0d74c Oct 22, 2016
@bbondy
Copy link
Member

bbondy commented Oct 22, 2016

Sorry @bradleyrichter I had to revert this commit which was causing it.
Please feel free to re-land it once these issues are worked out.

Revert commit is here:
1e0d74c

@bbondy bbondy mentioned this issue Oct 22, 2016
Merged
This was referenced Oct 22, 2016
Closed
Closed
Closed
Closed
@bsclifton bsclifton mentioned this issue Nov 1, 2016
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team. feature/findbar QA/checked-Linux QA/checked-macOS QA/checked-Win64
Projects
None yet
Milestone
0.12.6dev
Development

No branches or pull requests
6 participants
@bbondy @alexwykoff @luixxiul @bsclifton @bradleyrichter @srirambv