Deleting newtab added as a bookmark crashes Brave

[srirambv]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
While testing 4888 found adding a newtab as bookmark by removing name and path and deleting it from bookmark manager causes crash

Expected behavior:
Should not add bookmark without name and path. And should not crash when deleting bookmark from bookmark manager

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64
• Brave Version:
  0.12.6 Preview 1
• Steps to reproduce:
  1. Open a new tab and click on the bookmark icon
  2. Remove the name and location
  3. Open bookmark manager and the newtab is shown as a bookmarked item
  4. Delete the newtab bookmark, Brave crashes
• Screenshot if needed:
  
• Any related issues:

cc: @bsclifton

[bbondy]

regression?

[srirambv]

Works fine on 0.12.5 no crash.

[alexwykoff]

The real issue is that the door hanger doesn't have the same validations as the add bookmark modal had.

[cezaraugusto]

I couldn't reproduce it running Ubuntu. It doesn't crash but makes me unable to remove the bookmark.

IMO we should do the same way as Chrome does and disable donebutton if both title/location fields are empty. Personally I don't think someone would want to have a bookmark with no info.