Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Online suggestions in autocomple must be async #5043

Closed
Sh1d0w opened this issue Oct 22, 2016 · 0 comments
Closed

Online suggestions in autocomple must be async #5043

Sh1d0w opened this issue Oct 22, 2016 · 0 comments

Comments

@Sh1d0w
Copy link

Sh1d0w commented Oct 22, 2016

Did you search for similar issues before submitting this one?

No

Describe the issue you encountered:

Currently online suggestions that appear when you type in the URL bar are not async, blocking the suggestions list from rendering if you have slow internet connection. See the video http://webm.land/media/H1Yb.webm

The request for retrieving suggestions is async xhr, but the logic that renders the suggestions is not (which opens another bug that the first online suggestions that arrive are not displayed) ...

Expected behavior:

URL bar autocomplete must provide best experience for the user, instantly showing history and bookamrk matches and online suggestions when they arrive, just like Chrome and FF do.

  • Platform (Win7, 8, 10? macOS? Linux distro?): All
  • Brave Version: 0.12.6
  • Steps to reproduce:
    1. Connect to slow network
    2. Start typing in the url bar
    3. Wait 5 min for suggestions
  • Screenshot if needed:
  • Any related issues:
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants