Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Form elements are nested too deeply #5095

Closed
jkup opened this issue Oct 24, 2016 · 2 comments
Closed

Form elements are nested too deeply #5095

jkup opened this issue Oct 24, 2016 · 2 comments
Assignees
@jkup
Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 refactoring
Milestone
0.12.10 release

Comments

@jkup
Copy link
Contributor

jkup commented Oct 24, 2016

This also relates to #4884 but our form elements like input[type="text"] and general button.browserButton are nested too deeply (inside 3 classes) so that in order to get the styling you need to import settingsList and settingsListItem.

Since we want consistent form styling all throughout the settings pages we should pull those styles out into the top level of preferences.js.
@jkup jkup added the design A design change, especially one which needs input from the design team. label Oct 24, 2016
@jkup jkup added this to the 0.12.8dev milestone Oct 24, 2016
@jkup jkup self-assigned this Oct 24, 2016
@bbondy bbondy modified the milestones: 0.12.9dev, 0.12.8dev Oct 29, 2016
@jkup jkup mentioned this issue Nov 7, 2016
Merged
4 tasks
@jkup jkup modified the milestones: 0.12.10 release , 0.12.9dev Nov 8, 2016
This was referenced Nov 21, 2016
Closed
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

QA steps not mentioned

@luixxiul
Copy link
Contributor

@srirambv ? -> #5442 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jkup jkup

Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 refactoring
Projects
None yet
Milestone
0.12.10 release
Development

No branches or pull requests
5 participants
@jkup @bbondy @alexwykoff @luixxiul @srirambv