Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adjust widevine flow for ease of use #5131

Closed
bradleyrichter opened this issue Oct 25, 2016 · 3 comments
Closed

Adjust widevine flow for ease of use #5131

bradleyrichter opened this issue Oct 25, 2016 · 3 comments
Assignees
Labels
design A design change, especially one which needs input from the design team. plugin/widevine QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone

Comments

@bradleyrichter
Copy link
Contributor

The initial implementation required 2 separate alert bars and a trip to Brave preferences.

This approach allows the first-time Brave "streamer" to complete the task in a single alert bar plus a dialog but retains the same legalese.

step one. User visits netflix.com (example) and receives alert bar.

image

Step two. User clicks "allow" and a modal dialog opens:

image

(checkbox from bar is translated and made available on bottom of dialog)

If a new site requires "allow" after this initial installation dialog, only the bar will be shown.

If a user wishes to uninstall the plugin (effecting all sites that require it) they may disable it from the Brave Prefs panel:

image

@bradleyrichter bradleyrichter added this to the 0.12.7dev milestone Oct 25, 2016
@bbondy
Copy link
Member

bbondy commented Oct 26, 2016

@EuNlope this is only available in 0.12.7 which hasn't shipped yet

@ghost
Copy link

ghost commented Oct 26, 2016

Ok I'm sorry.

@luixxiul luixxiul added design A design change, especially one which needs input from the design team. feature/extensions labels Oct 26, 2016
@bbondy bbondy self-assigned this Oct 26, 2016
@bbondy
Copy link
Member

bbondy commented Oct 27, 2016

Didn't make it as pretty but it's consistent with the rest of the app, this is what I ended up with since this is short notice task / spec change to begin with:
screenshot 2016-10-27 00 43 48

New flow:

  1. Go to netflix.com
  2. Click Install and Allow

It reloads when installed (which is almost instant, then enjoy netflix).

Other use cases:

If you cancel instead of install, it just doesn't show anything until the next page load on netflix where it will show the dialog again.

You can still go and install via preferences which looks slightly different now too and install that way:

screenshot 2016-10-27 00 46 01

If you do that, or if you unclick the remember always from the first dialog & visit in a diff tab later, you get a normal permissions hanger:

screenshot 2016-10-27 00 48 32

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. plugin/widevine QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Development

No branches or pull requests

6 participants