Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Use POST StartPage #5235

Closed
privatzee opened this issue Oct 28, 2016 · 2 comments
Closed

Use POST StartPage #5235

privatzee opened this issue Oct 28, 2016 · 2 comments

Comments

@privatzee
Copy link
Contributor

IMO, StartPage is better than DuckDuckGo because:

  • it has their proxy, which you can use from the search results page for a quick look-see
  • you can use it without javascript enabled, whereas DDG makes you click to get the noscripting page
  • it's not in the USA whereas IIRC DDG is in the USA

Suggestion: make POST requests instead of GET, so there's no GET request data in Brave history or server logs

(I'm glad that I read the details for the update and so knew you added StartPage. Bravo.)

@bbondy bbondy changed the title THANK YOU for StartPage!! + suggestion Use POST StartPage Oct 31, 2016
@bbondy
Copy link
Member

bbondy commented Oct 31, 2016

Good suggestion, thanks. btw for DDG we have special handling for noscript to use that resource endpoint instead.

@bsclifton
Copy link
Member

bsclifton commented Dec 1, 2016

This is an interesting one; we can and should (for privacy reasons) implement HTTP POST for any provider (if they support it)...

The challenge might be the initial search (cc: @bbondy to sanity check me). Our search provider logic is currently filling in a string (ex: "http://searchEngine.com/{searchTermsHere}" and then navigating directly there (which I believe is doing an HTTP GET).

I'd have to check (and I could be very wrong), but I believe most browsers will do an HTTP GET when you hit enter to submit

@bsclifton bsclifton self-assigned this Dec 1, 2016
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton removed their assignment Mar 20, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants