Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about:newtab - favicons are not always shown #5310

Closed
bsclifton opened this issue Nov 1, 2016 · 1 comment · Fixed by #5361
Closed

about:newtab - favicons are not always shown #5310

bsclifton opened this issue Nov 1, 2016 · 1 comment · Fixed by #5361
Assignees
@bsclifton
Labels
feature/newtab QA/checked-Linux QA/checked-macOS QA/checked-Win64
Milestone
0.12.9dev

Comments

@bsclifton
Copy link
Member

When visiting sites, the favicon URL is being captured (thanks to #5285)

Not all of the sites are showing their favicon though. It seems this can be fixed by bookmarking the site.

Steps to reproduce:

  1. Visit https://duckduckgo.com/about
  2. Open about:newtab and you should see this site without an icon
  3. Bookmark the site
  4. Open about:newtab and you should see duckduckgo with the correct favicon
@srirambv
Copy link
Collaborator

srirambv commented Nov 2, 2016

FavIcons is inconsistent on tiles. Not all tiles have the favicon

image

@cezaraugusto cezaraugusto mentioned this issue Nov 2, 2016
Closed
@bsclifton bsclifton added this to the 0.12.9dev milestone Nov 3, 2016
@bsclifton bsclifton self-assigned this Nov 3, 2016
@bsclifton bsclifton mentioned this issue Nov 3, 2016
Merged
4 tasks
This was referenced Nov 10, 2016
Closed
Closed
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Nov 14, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
feature/newtab QA/checked-Linux QA/checked-macOS QA/checked-Win64
Projects
None yet
Milestone
0.12.9dev
Development

Successfully merging a pull request may close this issue.

Created session helper for newTabState
3 participants
@alexwykoff @bsclifton @srirambv