Fetch favicons first

[luixxiul]

Describe the issue you encountered: To confirm #2747 was fixed you have to wait until the page is loaded completely, maybe onload is fired.

Expected behavior: Because the interface is always active whether the page is loaded completely or not, the browser should find favicons and load them as soon as possible. We should not wait until the page is loaded completely.

• Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10

• Brave Version: 0.12.8 RC1

• Steps to reproduce:

  1. Clear browser's cache
  2. Open https://tokyo.cawaii.media/gisele/ and go back asap, before the favicon is fetched lastly
  3. Long click the go forward button to display the pulldown

• Any related issues: In some cases favicon is not displayed in history pulldown #2747 Favicon DDOS #2879 Cache favicons (to prevent fetching each time Brave is reloaded) #2697

[bsclifton]

Chromium is loading the favicons and electron is firing the event which notifies us that the favicon was loaded. For example, see

browser-laptop/js/components/frame.js

Line 806 in cea5023

windowActions.setFavicon(this.frame, e.favicons[0])

The favicon can't be loaded before the initial page is loaded (and honestly shouldn't be loaded until all other resources are loaded). Folks could probably add the meta tags in dynamically for the favicon using JavaScript and I would imagine this wouldn't be detected until page ready. Closing this as won't fix.