You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Favicons are loaded throughout the browser. When they are missing, it looks really bad, since there is not a fallback image.
Expected behavior:
For about:newtab, the tiles can fallback to the letter being used. For other places, a default document icon can be used.
NOTE: this is a great opportunity to create a new React control which loads the image using background-url... but also loads the image using a hidden tag, which has the onerror handler. This functionality can be used in multiple places, including the background image that's shown in about:newtab
Platform (Win7, 8, 10? macOS? Linux distro?):
All
Brave Version:
0.12.9 and newer
Steps to reproduce:
Go to a site that has a broken favicon
Go to about:newtab
Notice favicon is broken
Screenshot if needed: one to look for is in the top left tile
Any related issues:
The text was updated successfully, but these errors were encountered:
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Favicons are loaded throughout the browser. When they are missing, it looks really bad, since there is not a fallback image.
Expected behavior:
For about:newtab, the tiles can fallback to the letter being used. For other places, a default document icon can be used.
NOTE: this is a great opportunity to create a new React control which loads the image using background-url... but also loads the image using a hidden tag, which has the onerror handler. This functionality can be used in multiple places, including the background image that's shown in about:newtab
Platform (Win7, 8, 10? macOS? Linux distro?):
All
Brave Version:
0.12.9 and newer
Steps to reproduce:
Screenshot if needed:
one to look for is in the top left tile
Any related issues:
The text was updated successfully, but these errors were encountered: