Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Favicons need onerror handler (as seen in about:newtab) #5455

Closed
bsclifton opened this issue Nov 7, 2016 · 2 comments · Fixed by #5826
Closed

Favicons need onerror handler (as seen in about:newtab) #5455

bsclifton opened this issue Nov 7, 2016 · 2 comments · Fixed by #5826

Comments

@bsclifton
Copy link
Member

bsclifton commented Nov 7, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Favicons are loaded throughout the browser. When they are missing, it looks really bad, since there is not a fallback image.

Expected behavior:
For about:newtab, the tiles can fallback to the letter being used. For other places, a default document icon can be used.

NOTE: this is a great opportunity to create a new React control which loads the image using background-url... but also loads the image using a hidden tag, which has the onerror handler. This functionality can be used in multiple places, including the background image that's shown in about:newtab

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version:
    0.12.9 and newer

  • Steps to reproduce:

    1. Go to a site that has a broken favicon
    2. Go to about:newtab
    3. Notice favicon is broken
  • Screenshot if needed:
    one to look for is in the top left tile
    image

  • Any related issues:

@luixxiul
Copy link
Contributor

This should be fixed soon.

@luixxiul
Copy link
Contributor

Test plan: #5826 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.