Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Magnifying glass shown on about pages on Master build #5497

Closed
srirambv opened this issue Nov 8, 2016 · 4 comments · Fixed by #5600
Closed

Magnifying glass shown on about pages on Master build #5497

srirambv opened this issue Nov 8, 2016 · 4 comments · Fixed by #5600
Assignees
Labels

Comments

@srirambv
Copy link
Collaborator

srirambv commented Nov 8, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Magnifying glass shown on about pages on Master build. Also the text is not center aligned

Expected behavior:
Should not show the magnifying glass icon for the about pages

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version:
    master

  • Screenshot if needed:
    image

    Icons suggested by @bradleyrichter
    image

    cc: @bsclifton

@srirambv srirambv added design A design change, especially one which needs input from the design team. feature/URLbar labels Nov 8, 2016
@srirambv srirambv added this to the 0.12.10 release milestone Nov 8, 2016
@bsclifton bsclifton self-assigned this Nov 9, 2016
@srirambv
Copy link
Collaborator Author

srirambv commented Nov 9, 2016

Also shows on error pages
image

@bradleyrichter
Copy link
Contributor

we could probably use stacked FA icons to replicate the icon in this error page? That would work best.

@bsclifton
Copy link
Member

@bradleyrichter The error page is also an about page; (even though it may not show in the URL bar). Any preference for which of the 3 icons you shared is best?

@bradleyrichter
Copy link
Contributor

FA-list

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants