Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"Print" button on Google Calendar opens a new window throwing an error #5688

Closed
SilverPuppy opened this issue Nov 16, 2016 · 20 comments
Closed
Labels
bug needs-owner ♞ This issue is tagged for an upcoming release but has no owner. webcompat

Comments

@SilverPuppy
Copy link

SilverPuppy commented Nov 16, 2016

Describe the issue you encountered: "Print" button on the Google Calender does not work. Here is the output on devtool:

Failed to load resource: net::ERR_BLOCKED_BY_CLIENT static/3ed9ce8af0e9c1d0d763a066f187eef8doozercompiled_vr.css
static/3ed9ce8af0e9c1d0d763a066f187eef8delayloadedcompiled_vr.css Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
rs=ANwU0p4awk1Fr2euocPjD7MmSbo1y621WA Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
render:3 Uncaught ReferenceError: gcal is not defined
    at initPrintDialog (render:3)
    at onload (render#main_7:1)
  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10

  • Brave Version (revision SHA): 0.14.1

  • Steps to reproduce:

    1. Visit https://calendar.google.com
    2. Click "More"
    3. Select "Print"
  • Actual result: The new window with print preview is opened with no preview and infinite loading. The URL on the URL bar is about:blank. Disabling the shield does not work.

  • Expected result: The preview should be displayed

  • Is this an issue in the currently released version? Yes

  • Can this issue be consistently reproduced? Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    clipboard01

  • Any related issues:

@SilverPuppy
Copy link
Author

I can confirm that as of the most recent update today the issue still exists.

@cndouglas
Copy link

@SilverPuppy Have you tried disabling shields? While on the site, click the Brave lion logo in the top right corner and switch Shields to Down.

@SilverPuppy
Copy link
Author

I just tried that, and the result was the same. If it matters it's Win7 64.

I would not expect the shields to have any effect on this issue, as it seems to be a compatibility issue between the PDF.js viewer being used in Brave and the PDF content being generated by Google.

If I had my way, we wouldn't be using Google Calendar, or any other Google product, for that matter, but I'm not the manager.

@cndouglas
Copy link

@SilverPuppy If you think the PDF viewer is the problem, could you try turning it off? Open Preferences and select Advanced. Under the Extensions section, turn off Enable HTML5 PDF reader.

@SilverPuppy
Copy link
Author

SilverPuppy commented Nov 22, 2016

Turning off the built-in PDF reader allows the printable view PDF to be successfully downloaded, viewed, and printed externally with Adobe Reader.

EDIT: The PDF carries a flag to print-upon-open. If the built-in reader doesn't understand it, could this cause the issue?

@cndouglas
Copy link

That could be the issue. Since Brave uses the same reader as Firefox (pdfJS), maybe the Brave version has a bug that doesn't exist in the Firefox version. I'm not sure, though.

@SilverPuppy
Copy link
Author

More details:

"PDF.js v1.5.444 (build: b9e60a2)
Message: Invalid PDF structure"

@SilverPuppy
Copy link
Author

I just realized that Firefox says that the document may not be displayed correctly when the document is opened. It is, but obviously there is something in the PDF that the Firefox version doesn't understand as well, but the FF version ignores the error and continues to render, whereas the Brave version just fails.

@SilverPuppy
Copy link
Author

Nobody is paying any attention to this, apparently, which is puzzling, since it affects a widely-used tool and a widely-used data format. Is there perhaps a flag that can be passed to the PDF.js viewer when it is invoked to cause it to continue on errors instead of aborting? It looks to me like there is, and Firefox is doing so, which would be a good thing to do.

@cndouglas
Copy link

Maybe related: #6188

@luixxiul luixxiul added this to the Backlog milestone Feb 1, 2017
@cndouglas
Copy link

While trying to test this problem, I was unable to print at all: #7480.

@SilverPuppy
Copy link
Author

SilverPuppy commented Mar 3, 2017

That is because of another bug #7326 which has been resolved but not in the current released build.

EDIT: looked again. Might not be.

@cndouglas
Copy link

cndouglas commented Mar 3, 2017

@SilverPuppy Yeah, maybe not. It's still not working with 0.13.5 RC3 (1db81cb, Muon 2.56.8) either.

@SilverPuppy
Copy link
Author

I think I misread your bug report originally. #7326 pertained to a Windows printing system error, but #7480 looks like a page load issue with the main page.

@luixxiul luixxiul added the bug label Mar 31, 2017
@luixxiul luixxiul changed the title Google Calendar print function generates an "Invalid or corrupted PDF" error message "Print" button on Google Calendar opens a new window throwing an error Apr 1, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Apr 1, 2017

@SilverPuppy I updated the 1st post to make the bug reproducible more easily

@luixxiul luixxiul modified the milestones: 0.14.2, Backlog Apr 1, 2017
@cndouglas
Copy link

@luixxiul I think there are two separate problems here. This issue is about PDF.js not opening PDFs generated by Google Calendar. The issue I filed (#7480) is about the Google Calendar print window error.

@bsclifton
Copy link
Member

Moving to 0.14.3

@bsclifton bsclifton modified the milestones: 0.14.3, 0.14.2 Apr 4, 2017
@bsclifton bsclifton removed the needs-owner ♞ This issue is tagged for an upcoming release but has no owner. label Apr 7, 2017
@bsclifton bsclifton added needs-owner ♞ This issue is tagged for an upcoming release but has no owner. and removed needs-owner ♞ This issue is tagged for an upcoming release but has no owner. labels Apr 7, 2017
@alexwykoff alexwykoff modified the milestones: 1.1.0, 0.15.1 Apr 18, 2017
@SilverPuppy
Copy link
Author

Still not working as of update today.

@SilverPuppy
Copy link
Author

Working as of update today! Thanks everyone! I no longer have to keep FireFox open just for Google Calendar!

@bsclifton bsclifton removed this from the 1.1.0 milestone May 29, 2017
@bsclifton
Copy link
Member

Thanks for the update, @SilverPuppy! Please re-open this issue if you experience the issue again 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug needs-owner ♞ This issue is tagged for an upcoming release but has no owner. webcompat
Projects
None yet
Development

No branches or pull requests

5 participants