[Request] Add setting to turn off modal darkening effect

[Gelo3D]

Did you search for similar issues before submitting this one?

yes

Describe the issue you encountered:

Please do options to turn off/on darker effect -

Its really cool and important to bad / slow pcs/laptops.

Expected behavior:

• Platform (Win7, 8, 10? macOS? Linux distro?):

• Brave Version:

• Steps to reproduce:
  1.
  2.
  3.

• Screenshot if needed:

• Any related issues:

[cndouglas]

Renamed to be more general. Other actions, such as the Clear Browsing Data panel, also darken the current window.

[bradleyrichter]

I agree with @Gelo3D on this one. There really is no point in having the darkening effect with most of our dialogs. Darkening should only be used on modal dialogs.

cc @bsclifton

[bsclifton]

This is an interesting one...

The purpose of the dark is to show that there is an overlay. For example (using the screenshot above), the dark colored area is where you need to click in order to hide the bravery menu

If we didn't show an overlay, users may expect that they could click on any UI elements and it would work as expected. If that is the desired behavior, this would become a larger change. Also, we'd need to define what happens in this scenario:

• You click lion head, open Bravery. Let's say there is no overlay anymore
• You can click refresh button, even with Bravery Menu up
• The click refreshes the page

At this point, do we hide the Bravery menu? or do we keep it open, since the user never chose to close it?

The overlay forces you to close the modal before using the browser again

[bradleyrichter]

I call hogwash based on other dropdown panels. ; )

[cndouglas]

Related: #3653

[lucidNTR]

+1

[luixxiul]

Fixed with #3653