Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Place the footer on the contribution report properly #6061

Closed
luixxiul opened this issue Dec 7, 2016 · 1 comment · Fixed by #6047
Closed

Place the footer on the contribution report properly #6061

luixxiul opened this issue Dec 7, 2016 · 1 comment · Fixed by #6047
Assignees
@luixxiul
Labels
feature/rewards misc/button QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 7, 2016 •
edited
Loading

Describe the issue you encountered:

#6039 (comment) courtesy of @mrose17

The OK button is not placed properly (see attachment)

0

Expected behavior:

place OK button properly
@luixxiul luixxiul added this to the 0.13.1 milestone Dec 7, 2016
@luixxiul luixxiul self-assigned this Dec 7, 2016
This was referenced Dec 7, 2016
Merged
Merged
@luixxiul luixxiul mentioned this issue Dec 15, 2016
Closed
@luixxiul luixxiul modified the milestones: 0.13.0, 0.13.1 Dec 15, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor Author

luixxiul commented Jan 16, 2017 •
edited
Loading

Test plan:

Disable the ledger
Run npm run add-simulated-payment-history some times
Enable the ledger
Click "View Payment History..."
Make sure the button in the footer is placed like this:

screenshot 2016-12-10 14 41 44

Click "OK" button

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/rewards misc/button QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Refactor about:preferences#payments followups
2 participants
@luixxiul @srirambv