Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Favicons missing from the bookmarks bar #6077

Closed
khaosdoctor opened this issue Dec 7, 2016 · 5 comments
Closed

Favicons missing from the bookmarks bar #6077

khaosdoctor opened this issue Dec 7, 2016 · 5 comments

Comments

@khaosdoctor
Copy link

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Some bookmarks I imported from chrome are missing favicons, even after I open and log into them

Also, some favicons are misplaced:

One of those (the left one) is pinterest, the other is gmail.

Expected behavior:
All Favicons should be loaded and cached when I enter the website

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS Sierra

  • Brave Version: 0.12.13

  • Steps to reproduce:

    1. Import content from chrome
    2. Access a website (like linkedin, twitter, gmail, stackoverflow, aws)
    3. Don't see the favicons
  • Screenshot if needed: Up in the description

@bradleyrichter
Copy link
Contributor

@bsclifton Can we add a forced refresh at some point that makes sense?

@bsclifton
Copy link
Member

@bradleyrichter yes- we should be able to do that. We'd want to do something creative, like load all the icons in a hidden webview (so that it takes advantage of existing events)

@pascalwhoop
Copy link

I have observed a similar issue with my bookmark favicons having been manually loaded after import (by opening the websites a couple of times and let them sit there for a minute until the bookmark favicon was set), but now they disappeared again. Not sure why, I assume caching of some sort.

I also noticed that the only way to get both favicons without text and folders with text is using the "favicon and text" and then putting a space for the name of the favicon. If it doesn't have a name it defaults back to the URL which can only be prevented if the bookmarks name is !=""

@khaosdoctor
Copy link
Author

I think this has been addressed on #6078

@luixxiul luixxiul added the bug label Jun 4, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@jamesray1
Copy link

Similarly sometimes no favicons show, so I have to close the bookmarks toolbar and reopen it.

Brave: 0.20.42
V8: 6.4.388.41
rev: 096c7cb
Muon: 4.8.2
OS Release: 4.13.0-36-generic
Update Channel: Release
OS Architecture: x64
OS Platform: Linux
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 64.0.3282.140

@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants