Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove a dark background to the bottom layer if the modal contains .coinbaseOverlay #6093

Closed
luixxiul opened this issue Dec 8, 2016 · 6 comments
Labels
design A design change, especially one which needs input from the design team. feature/rewards suggestion wontfix

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 8, 2016

Describe the issue you encountered: #4820 (comment)

Add .last to the modal overlay unless the modal contains .coinbaseOverlay. The iframe inside .coinbaseOverlay itself has the dark background.

  • Brave Version: macOS

  • Any related issues:

CC @willy-b

@luixxiul luixxiul added design A design change, especially one which needs input from the design team. feature/rewards labels Dec 8, 2016
@willy-b
Copy link
Contributor

willy-b commented Dec 8, 2016

Nice. You can assign this to me if you want and if it can wait until after PRs #5809 and #6039

@mrose17
Copy link
Member

mrose17 commented Jan 19, 2017

@willy-b - any luck?

@willy-b
Copy link
Contributor

willy-b commented Jan 20, 2017

was going to do this after #6039 but that is still outstanding. I'm actually out of cycles for a while now, you should probably reassign this.

@mrose17
Copy link
Member

mrose17 commented Jan 20, 2017

@willy-b - understood, thanks and no worries!

@mrose17 mrose17 added this to the 0.13.2 milestone Jan 20, 2017
@mrose17 mrose17 modified the milestones: 1.0.0, 0.13.3 Feb 2, 2017
@luixxiul
Copy link
Contributor Author

I tried and I came to a conclusion that the background layer of coinbase iframe widget should be removed instead of our modal overlay. If we remove the background of modal overlay, lag occurs after clicking the button until the coinbase widget is actually rendered.

@mrose17
Copy link
Member

mrose17 commented May 24, 2017

i'm going to mark this as "won't fix"... for the reasons above (and awaiting the new addfunds service). thanks very much for researching it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/rewards suggestion wontfix
Projects
None yet
Development

No branches or pull requests

3 participants