Vimium: Icon not displayed near address bar

[jonathansampson]

Test Plan:

An extension's manifest file may contain a browser_action.default_icon property. This property usually holds an object, but may (in older extensions) hold a string. String paths to images were not being handled by Brave, which caused some extensions (such as Vimium) to have no displayed icon.

To test this, install the Vimium extension in your development build of Brave. Vimium's extension ID is dbepggeogbaibhgnhhndojpepiihcmeb. With this extension registered and loaded, running Brave should reveal the Vimium icon near the Brave Shield icon.

This commit also prevents the redundant look-up of manifest.browser_action.default_icon (path is already a reference to browser_action.default_icon). Also, manifest.icons should not be the source for browser action icons.

Original issue description

Describe the issue you encountered:
Upon loading the Vimium extension, there was no icon displayed near the address bar.

Work-around:
Adding the following (borrowed from manifest.icon) to the manifest.browser_action object resolves:

"default_icon": {
  "19": "icons/icon16.png",
  "38": "icons/icon48.png"
}

Brave Version: 0.12.15

[luixxiul]

@jonathansampson do we need QA for this issue, or is this postponed until Vinium extension becomes ready?

[jonathansampson]

@luixxiul The root issue is resolved; this is good closed :)

[jonathansampson]

Reopening as manifest.icons is the wrong way to go about solving this problem. Seeing the comments on #7500 to better understand the correct approach.

[srirambv]

Added no-qa-requried as the extension is not available in packaged build for testing