Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Extension API: chrome.browserAction.setIcon w/ imageData #6197

Closed
jonathansampson opened this issue Dec 14, 2016 · 3 comments
Closed

Extension API: chrome.browserAction.setIcon w/ imageData #6197

jonathansampson opened this issue Dec 14, 2016 · 3 comments
Labels
bug feature/extensions fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. needs-owner ♞ This issue is tagged for an upcoming release but has no owner. wontfix

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Dec 14, 2016

Describe the issue you encountered:
Brave's implementation of chrome.browserAction.setIcon does not presently support imageData objects. As a result, the following (taken from the Vimium extension) fails:

chrome.browserAction.setIcon({
  tabId: tabId,
  imageData: (function() {
    var enabledStateIcon;
    enabledStateIcon = !enabledState.isEnabledForUrl ? DISABLED_ICON : 0 < enabledState.passKeys.length ? PARTIAL_ICON : ENABLED_ICON;
    return iconImageData[enabledStateIcon];
})()

Expected behavior:
Brave should accept imageData objects as an argument to chrome.browserAction.setIcon.

Blocks #9531, #9654

@jonathansampson jonathansampson added this to the 0.13.6 milestone Mar 2, 2017
@jonathansampson jonathansampson changed the title Vimium: chrome.browserAction.setIcon doesn't support ImageData objects chrome.browserAction.setIcon doesn't support ImageData objects Mar 2, 2017
@bsclifton
Copy link
Member

moving to 0.13.7

@bsclifton bsclifton modified the milestones: 0.13.7, 0.13.6 Mar 14, 2017
@bsclifton
Copy link
Member

Moving to 0.14.3

@bsclifton bsclifton modified the milestones: 0.14.3, 0.14.2 Apr 4, 2017
@bsclifton bsclifton added needs-owner ♞ This issue is tagged for an upcoming release but has no owner. and removed needs-owner ♞ This issue is tagged for an upcoming release but has no owner. labels Apr 4, 2017
@alexwykoff alexwykoff modified the milestones: Backlog, 0.15.1 Apr 18, 2017
@alexwykoff
Copy link
Contributor

cc @kevinlawler

@jonathansampson jonathansampson mentioned this issue Jun 16, 2017
47 tasks
@jonathansampson jonathansampson changed the title chrome.browserAction.setIcon doesn't support ImageData objects Extension API: chrome.browserAction.setIcon w/ imageData Jun 17, 2017
@bbondy bbondy removed this from the Backlog milestone Oct 19, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton added fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix labels Jul 25, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug feature/extensions fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. needs-owner ♞ This issue is tagged for an upcoming release but has no owner. wontfix
Projects
None yet
Development

No branches or pull requests

4 participants