Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"No saved addresses/credit cards" messages and the autofill list lack margins around them #6328

Closed
luixxiul opened this issue Dec 20, 2016 · 2 comments
Closed

"No saved addresses/credit cards" messages and the autofill list lack margins around them #6328

luixxiul opened this issue Dec 20, 2016 · 2 comments
Assignees
@luixxiul
Labels
feature/autofill misc/button polish Nice to have — usually related to front-end/visual tasks. QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude settings
Milestone
0.13.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 20, 2016 •
edited
Loading

Describe the issue you encountered:
"No saved addresses/credit cards" messages and the autofill list lack margins around them

This is the regression caused by https://github.com/brave/browser-laptop/pull/5916/files#diff-fca7d0eef4fe1430dbdc3733b1fc5fdaR11 of #5916

Expected behavior:
Margins should be added

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version: master branch

  • Steps to reproduce:

    1. Open about:autofill
    2. Delete entries if any

  • Screenshot if needed:

screenshot 2016-12-20 22 59 57

  • Any related issues:
@luixxiul luixxiul added feature/autofill polish Nice to have — usually related to front-end/visual tasks. settings labels Dec 20, 2016
@luixxiul luixxiul self-assigned this Dec 20, 2016
@luixxiul luixxiul mentioned this issue Dec 20, 2016
Merged
4 tasks
@bsclifton bsclifton added this to the 0.13.0 milestone Dec 21, 2016
@luixxiul luixxiul reopened this Dec 30, 2016
@luixxiul
Copy link
Contributor Author

luixxiul commented Dec 30, 2016 •
edited
Loading

#6329 did not fix this issue:

screenshot 2016-12-30 18 57 40

Pushing a fix.

Also I labelled release-note/exclude as the issue appeared and is fixed within the same milestone.

@luixxiul luixxiul mentioned this issue Dec 30, 2016
Merged
4 tasks
@luixxiul luixxiul changed the title "No saved addresses/credit cards" messages lack margins around them "No saved addresses/credit cards" messages and the autofill list lack margins around them Dec 30, 2016
@luixxiul
Copy link
Contributor Author

Test plan:

Open about:autofill
Delete entries if any
Add an entry

@luixxiul luixxiul mentioned this issue Jan 20, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/autofill misc/button polish Nice to have — usually related to front-end/visual tasks. QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude settings
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
3 participants
@luixxiul @bsclifton @srirambv