Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

PDF doesn't load when opened but work by clicking on the link #6330

Closed
srirambv opened this issue Dec 20, 2016 · 9 comments
Closed

PDF doesn't load when opened but work by clicking on the link #6330

srirambv opened this issue Dec 20, 2016 · 9 comments

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
PDF doesn't load when opened but work by clicking on the link

Expected behavior:
PDF files should open when opened/clicking the link

@bridiver
Copy link
Collaborator

@jonathansampson @bbondy do you know if anything changed here? We have never supported sync storage

@bbondy
Copy link
Member

bbondy commented Dec 20, 2016

We did recently upgrade the pdfjs extension. @diracdeltas did you happen to build it differently from the time before? Maybe they just started using new apis?

@bbondy
Copy link
Member

bbondy commented Dec 20, 2016

@srirambv can you confirm if this is happening with 0.12.15 as well? I think it probably is.

@bbondy
Copy link
Member

bbondy commented Dec 21, 2016

@diracdeltas did you have a chance to look at this? I'm afraid people on 0.12.15 are also affected

@srirambv
Copy link
Collaborator Author

@bbondy Opening the link works on 0.12.15.

@srirambv
Copy link
Collaborator Author

@bbondy Verified on 0.12.15 on both Windows 10 & Windows 7. Opening the link works

@diracdeltas
Copy link
Member

i have a fix for this

@diracdeltas diracdeltas self-assigned this Dec 21, 2016
@bbondy
Copy link
Member

bbondy commented Dec 21, 2016

Yan fixed here:
diracdeltas/pdf.js@3e4164f

I updated our extension update server here:
brave/vault-updater@f805d47

@luixxiul
Copy link
Contributor

Test plan: available on the 1st post.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.