Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Spell check is not working for C54 #6507

Closed
bbondy opened this issue Jan 3, 2017 · 4 comments
Closed

Spell check is not working for C54 #6507

bbondy opened this issue Jan 3, 2017 · 4 comments

Comments

@bbondy
Copy link
Member

bbondy commented Jan 3, 2017

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Spell check isn't working

Expected behavior:
Spell check should work

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    master tip:
    c2fa12f

  • Steps to reproduce:

    1. Go to https://github.com/fdafadsfdsafdsa
    2. Type a bunch of characters randomly into the input box
  • Actual results: No underline happens

  • Expected results: underline happens

@bbondy bbondy added this to the 0.13.0 milestone Jan 3, 2017
@bbondy bbondy self-assigned this Jan 3, 2017
@bbondy
Copy link
Member Author

bbondy commented Jan 3, 2017

This seems to be ICU related, everything seems to be working correctly except for the word iterator doesn't find any words even know there is text. This can probably be closed when ICU is fixed.

@bbondy bbondy changed the title Spell check is not working for C54 Spell check is not working for C54 b/c of ICU Jan 3, 2017
@bbondy bbondy changed the title Spell check is not working for C54 b/c of ICU Spell check is not working for C5 Jan 12, 2017
@bbondy bbondy changed the title Spell check is not working for C5 Spell check is not working for C54 Jan 12, 2017
@bbondy
Copy link
Member Author

bbondy commented Jan 12, 2017

This seems to NOT work still even know ICU is fixed.

@bbondy
Copy link
Member Author

bbondy commented Jan 15, 2017

Edited typo above, I meant to say this was not related to ICU at all, it turned out to just be a problem with our handling due to enumeration value for a word token because 0 which breaks out of the while loop and doesn't check any words.

The fix will be available in Preview9. For testing you just need to make sure spell check works now the same as it did in 0.12.15.

@luixxiul
Copy link
Contributor

I added release-notes/exclude as the issue appeared and was fixed within the same milestone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants