Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Convert font sizes to relative units #6527

Closed
jkup opened this issue Jan 4, 2017 · 3 comments
Closed

Convert font sizes to relative units #6527

jkup opened this issue Jan 4, 2017 · 3 comments
Labels
accessibility design A design change, especially one which needs input from the design team. stale

Comments

@jkup
Copy link
Contributor

jkup commented Jan 4, 2017

Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:
This should just be the parent issue, as we move font sizes from pixesl to rems and ems we should track each component or each less file separately.

Expected behavior:
In order for us to easily allow users to scale the UI up and down we should use relative sizing units instead of pixels. I'm quite partial to this CSS-Tricks post where you use:

Pixels - at the document level
Rems - at the component level
Ems - at the sub-component level

This would essentially be:

html { font-size: 14px; }

.MyComponent { font-size: 1.5rem; }

.MyComponent h2 { font-size: 2em; }

The idea here is that components scale with the document and items scale with their parent component.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All.

  • Brave Version (revision SHA):
    Master.

  • Any related issues:

#2469
#5683
#5143
#1757

@jkup jkup added accessibility design A design change, especially one which needs input from the design team. labels Jan 4, 2017
@jkup jkup added this to the 1.2.0 milestone Jan 4, 2017
@NejcZdovc
Copy link
Contributor

@jkup do you need any help with this one?

@jkup
Copy link
Contributor Author

jkup commented Jan 5, 2017

@NejcZdovc definitely! I think the best thing to do would be to find small components that would be easy to convert and tackle them one at a time. It would also work nicely with our conversion to Aphrodite for styles (see https://github.com/brave/browser-laptop/blob/448604f08aa1f6d01708a4fd76aad1a807c6602b/app/renderer/components/tabIcon.js as an example).

If you're up for it we can find a component that would make for a good start!

@NejcZdovc
Copy link
Contributor

@jkup sure let's do this 😃

@alexwykoff alexwykoff modified the milestones: 1.2.0, Backlog Nov 1, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility design A design change, especially one which needs input from the design team. stale
Projects
None yet
Development

No branches or pull requests

4 participants