Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added extensions panel to about:preferences #6530

Closed
bradleyrichter opened this issue Jan 5, 2017 · 6 comments
Closed

Added extensions panel to about:preferences #6530

bradleyrichter opened this issue Jan 5, 2017 · 6 comments

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Jan 5, 2017

Test plan

See #8065

Original issue description

To increase awareness of Brave's extension support, and to funnel new extension requests, a new prefs panel will be created.

features:

  • all brave extensions will appear in a sortable list, sorted alphabetically by default
  • each extension can be enabled/disabled with a switch at the right side
    (this should toggle the presence of the extension in the point of integration)
  • if an extension is available but not installed by default, the switch begins as an "install" button
  • a rt-click menu is available to uninstall any extension that was once manually installed
  • a notification bar is triggered when new extensions become available to alert the user of the good news (this alert may be disabled)
  • a link is positioned at the bottom of the page to invite users to submit extension requests through the community portal

notes:

  • this panel is for extensions only and will not display plugins such as Flash or Widevine
  • after implementation, we will add a menu item to point users to this panel
    (Window>Extensions Manager...)

pasted image at 2017_02_27 04_21 pm

@bradleyrichter bradleyrichter added design A design change, especially one which needs input from the design team. feature/extensions impact/high labels Jan 5, 2017
@bradleyrichter bradleyrichter added this to the 1.0.0 milestone Jan 5, 2017
@willy-b
Copy link
Contributor

willy-b commented Jan 5, 2017

Any possibility to control other extension permissions in this or future mockups?

In Google Chrome, incognito mode / file URL permissions controls are exposed in their panel:
extensionsoptionsingooglechrome

(you might do it in your popup menu or elsewhere, but the functionality is useful)

@bradleyrichter
Copy link
Contributor Author

bradleyrichter commented Jan 5, 2017

Context menu should work as we are able/need to add this type of functionality. In the future, this will change based on the ability to open the extension API.

@bradleyrichter bradleyrichter modified the milestones: 0.13.2, 1.0.0 Jan 12, 2017
@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@bsclifton bsclifton added this to the 0.14.1 milestone Mar 21, 2017
@bsclifton
Copy link
Member

Pulling into 0.14.1

@bsclifton
Copy link
Member

Per discussion with @bbondy, let's

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 22, 2017

We also need to add on this panel enable/disable in the private/session tab, same as Chrome has it "Allow in incognito"

screen shot 2017-03-22 at 07 38 22

@luixxiul
Copy link
Contributor

How could I reload PDF reader which I accidentally removed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants