Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Several SyntaxErrors on latest master #6651

Closed
luixxiul opened this issue Jan 15, 2017 · 6 comments
Closed

Several SyntaxErrors on latest master #6651

luixxiul opened this issue Jan 15, 2017 · 6 comments

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered:

    ERROR in aboutPages.entry.js from UglifyJs
    SyntaxError: Unexpected token: name (ImmutableComponent) [./js/components/immutableComponent.js:7,6]
    
    ERROR in app.entry.js from UglifyJs
    SyntaxError: Unexpected token: name (ImmutableComponent) [./js/components/immutableComponent.js:7,6]
Child
    Hash: 3a4e7aff50182eeef0d9
    Version: webpack 1.14.0
    Time: 17029ms
                  Asset    Size  Chunks             Chunk Names
        lib.devTools.js  189 kB       0  [emitted]  devTools
    lib.devTools.js.map  241 kB       0  [emitted]  devTools
       [0] multi devTools 28 bytes {0} [built]
        + 9 hidden modules
    
    ERROR in lib.devTools.js from UglifyJs
    SyntaxError: Unexpected token: operator (>) [./js/lib/functional.js:11,33]
Child webtorrent:
    Hash: 96353c6b8a04d69991ef
    Version: webpack 1.14.0
    Time: 27293ms
                                     Asset       Size  Chunks             Chunk Names
      2ad15189f9772058209b9036ebf8bda1.svg    1.34 kB          [emitted]  
      8b116e3ce0b2711f8e2cc78c8b32a7c5.svg  485 bytes          [emitted]  
      196262d2122e55e514d47f9e44b66520.svg  431 bytes          [emitted]  
      674f50d287a8c48dc19ba404d20fe713.eot     166 kB          [emitted]  
      912ec66d7572ff821749319396470bde.svg     444 kB          [emitted]  
      b06871f281fee6b241d60582ae9369b9.ttf     166 kB          [emitted]  
    af7ae505a9eed503f8b8e6982036873e.woff2    77.2 kB          [emitted]  
     fee66e712a8a08eef5805a46892932ad.woff      98 kB          [emitted]  
                   webtorrentPage.entry.js     1.3 MB       0  [emitted]  main
               webtorrentPage.entry.js.map    1.56 MB       0  [emitted]  main
       [0] multi main 28 bytes {0} [built]
        + 313 hidden modules
    
    ERROR in webtorrentPage.entry.js from UglifyJs
    SyntaxError: Unexpected token: operator (>) [./js/lib/classSet.js:9,17]

Expected behavior:

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version (revision SHA): 567bd73

  • Steps to reproduce:

    1. CHANNEL=dev run build-package
  • Any related issues:

@luixxiul luixxiul added this to the 0.13.0 milestone Jan 15, 2017
@bbondy bbondy self-assigned this Jan 15, 2017
@bbondy
Copy link
Member

bbondy commented Jan 15, 2017

These are non fatal but I think it's because we reduced transpiling and uglifyJS doesn't support it. I'll see what we can do. There's an uglifyJS harmony branch we might be able to use.

@jonathansampson
Copy link
Collaborator

@bbondy I still see these issues:

image

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 31, 2017

@jonathansampson which command did you use to start this webpack run?

@jonathansampson
Copy link
Collaborator

jonathansampson commented Apr 1, 2017

@NejcZdovc npm run watch is all I ran to see the above output. Strangely, running it again, I'm not able to repro... I'll keep close watch to see if it happens again.

@bbondy
Copy link
Member

bbondy commented Apr 3, 2017

@diracdeltas I think this was working at some point but regressed.

@bsclifton
Copy link
Member

I always see these too, but it appears to be a warning (even though it says error). Everything works as expected

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants