Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Automated test failures on bookmarkToolbar #6663

Closed
2 of 3 tasks
luixxiul opened this issue Jan 16, 2017 · 7 comments
Closed
2 of 3 tasks

Automated test failures on bookmarkToolbar #6663

luixxiul opened this issue Jan 16, 2017 · 7 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jan 16, 2017

Describe the issue you encountered:

https://travis-ci.org/brave/browser-laptop/builds/192196021#L4577

  • 1) bookmarksToolbar when clicking a bookmark folder hides context menu when mousing over regular bookmark:
    Error: timeout of 30000ms exceeded. Ensure the done() callback is being called in this test.

  • 2) bookmarksToolbar when clicking a bookmark folder "after each" hook for "hides context menu when mousing over regular bookmark":
    Error: timeout of 30000ms exceeded. Ensure the done() callback is being called in this test.

https://travis-ci.org/brave/browser-laptop/builds/197222628#L4660
https://travis-ci.org/brave/browser-laptop/builds/197213036#L4692
https://travis-ci.org/brave/browser-laptop/builds/197205697#L4647
https://travis-ci.org/brave/browser-laptop/builds/197196928#L4656

  • 2) bookmarksToolbar display favicon on bookmarks toolbar display bookmark favicon for url that has it:
    WaitUntilTimeoutError: Promise was rejected with the following reason: timeout
    at execute() - brave.js:413:19

Expected behavior:

@luixxiul luixxiul added this to the Backlog milestone Jan 16, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Jan 16, 2017

@bbondy will you take a look at those if you don't mind?

@bbondy
Copy link
Member

bbondy commented Jan 16, 2017

I was just commenting that these are the most common failures in slack :)

@bbondy bbondy modified the milestones: 0.13.0, Backlog Jan 16, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Jan 16, 2017

I'm the winner!! :-D

@bbondy
Copy link
Member

bbondy commented Jan 17, 2017

I think these are fixed here
7670206

415e343

@bbondy bbondy closed this as completed Jan 17, 2017
@luixxiul luixxiul reopened this Feb 1, 2017
@luixxiul luixxiul modified the milestones: 0.13.0, Backlog Feb 1, 2017
@luixxiul luixxiul modified the milestones: 0.14.0, Backlog Mar 16, 2017
@bbondy bbondy modified the milestones: 0.14.0, 0.14.1 Mar 16, 2017
@bsclifton bsclifton modified the milestones: 0.14.3, 0.14.2 Apr 9, 2017
@alexwykoff alexwykoff self-assigned this Apr 18, 2017
@alexwykoff
Copy link
Contributor

These are the currently failing tests:

bookmark tests bookmarks pages without title "before all" hook:
     WaitUntilTimeoutError: Promise was rejected with the following reason: timeout
      at execute(<Function>) - brave.js:510:19

bookmarksToolbar display favicon on bookmarks toolbar display bookmark favicon for url that has it:
     WaitUntilTimeoutError: Promise was rejected with the following reason: timeout
      at execute(<Function>) - brave.js:510:19

They were ran repeatedly with a failing result.

@alexwykoff alexwykoff added this to the 0.16.200 milestone May 26, 2017
@alexwykoff
Copy link
Contributor

Double-check this @alexwykoff 😸

@bbondy bbondy removed this from the 0.18.x (Beta Channel) milestone Jul 11, 2017
@luixxiul
Copy link
Contributor Author

Closing as fixed & stale

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants