Auto-purging "Saved site settings" resets Payments "Include" toggles

[analogist]

Describe the issue you encountered:
It seems that the "Include" toggle state in Payments for individual sites does not survive browser restarts, if "Saved site settings and permissions" is set to autopurge on closing Brave.

Expected behavior:
I'm actually not sure if this is a technical limitation, but to me it seems like user settings in the about:* domains should survive purge-on-close.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 (v 1607)

• Brave Version (revision SHA):
  0.12.15

• Steps to reproduce:

  1. Turn on autopurge "Saved site settings and permissions" in "Security"/"Private Data"
  2. Turn on Brave Payments and form a payment ledger
  3. Toggle off some sites in the ledger with the "Include" toggle
  4. Restart Brave
  5. All sites are toggled back "on" in the "Include" list.

This issue does not seem to occur if "Saved site settings and permissions" is not set to autopurge.

[mrose17]

@bradleyrichter - is this the intended behavior? my thinking is that the behavior is consistent, but may not be desirable. what's your thinking?

[bradleyrichter]

My initial thinking and current thinking is that these MUST be separated because it will always surprise people. I think you need 2 options:

The standard and Brave specific:

(not sure if the last switch should combine those data types but it would be more usable. )

[diracdeltas]

@bradleyrichter 'brave shields' is essentially the same as 'saved site settings'. if you want shields to be tied with brave payments, then 'saved site settings and permissions' should probably just be 'saved site permissions'.

[bsclifton]

moving to 0.13.7

[diracdeltas]

should the 'Brave payments data' switch clear all Brave payments data (resetting it to the state before you turned on Brave payments)?

[mrose17]

the only issue with that is the loss of the brave wallet, if the user didn't back up the recovery keys... i suspect it would be better to trim everything back in the synopsis file, most of the ledger state file, and then set the ledger setting to off along with deleting all the site-specific ledger settings...

[mrose17]

here is my suggestion:

1. add the additional option "Brave shields and payment data" as shown in https://cloud.githubusercontent.com/assets/13509546/22130115/12199528-de5f-11e6-96f6-bb67c71c403c.png

2. exclude any key starting with ledger from being deleted when "Saved site settings and permissions" is cleared.

3. when "Brave shields and payment data" is cleared, reset ballots and transactions, and remove paymentInfo from ledger-state

4. when "Brave shields and payment data" is cleared, reset ledger-scores, ledger-publisher and ledger-log

5. when "Brave shields and payment data" is cleared, reset publishers from ledger-publishers

tasks 2-4 can be accomplished by modifying the correct data structures in app/ledger.js and then calling atomicWriter...

[diracdeltas]

shields should not be tied to payments data IMO. if you are clearing site permissions, you are more likely to want to clear shield settings than if you are clearing payments data.

[mrose17]

@bradleyrichter - i agree with @diracdeltas comment, we probably need two more checkboxes, not just one...

[bsclifton]

Prework for this is done and can be found in the issues-6708 branch

[LaurenWags]

+1 from community: https://community.brave.com/t/included-websites-are-not-saved-correctly-in-brave-payments/10879

[NejcZdovc]

per discussion with @diracdeltas we are pushing this after 1.0