Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed idle timer never stopping #6826

Closed
da2x opened this issue Jan 24, 2017 · 2 comments
Closed

Fixed idle timer never stopping #6826

da2x opened this issue Jan 24, 2017 · 2 comments

Comments

@da2x
Copy link
Contributor

da2x commented Jan 24, 2017

This is the same as #4051, but I forgot to follow up on that issue.

My top three websites this month are websites I’ve visited before going to bed. I’ve lefy Brave open over night and have ~8 hours recorded for each of these sites. Timer is supposed to stop after 15 minutes, but this still isn’t working.

Tested with v0.13.0dev-RC5 on Fedora Workstation 25 with GNOME. I tested the same version under Windows 10 with an empty profile, and I see the same issue.

Test case

  1. Disable screen saver/energy saver so screen doesn’t turn off
  2. Clean Brave profile, enable payments in settings
  3. Visit any domain a few times until it shows up on about:preferences#payments. Note the recorded time.
  4. Open a tab with that domain and don’t touch the PC for 30 minutes.

Expected: The domain should be recorded with the noted time + 15 minutes.

Actual: The domain is recorded with the noted time + 30 minutes.

@luixxiul
Copy link
Contributor

CC @mrose17 do you notice the issue?

@mrose17 mrose17 self-assigned this Jan 25, 2017
@mrose17 mrose17 added this to the 0.13.2 milestone Jan 25, 2017
@mrose17 mrose17 added the bug label Jan 31, 2017
@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@mrose17 mrose17 removed their assignment Feb 21, 2017
@bsclifton
Copy link
Member

+1 via #7486

Time Spent is presently too lenient. One site, left open when I walked away from my machine for the evening, was granted a Time Spent amount of over 10 hours. Other users report similarly skewed reports for domains in their list. See https://twitter.com/givanse/status/837495337455501313.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants